Skip to content

Conversation

@BobbieGoede
Copy link
Member

@BobbieGoede BobbieGoede commented Nov 6, 2025

🔗 Linked issue

📚 Description

Prerendering currently ignores changes made to pages/routes in pages:resolved.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Walkthrough

The change modifies a single file to replace the Pages extension hook event from pages:extend to pages:resolved. This alteration shifts the timing of when the hook is triggered within the module lifecycle. The hook is now called later in the process, specifically after the pages array has been resolved, rather than at the earlier extension point. This timing change affects when prerenderRoutes are processed and populated relative to subsequent operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Hook lifecycle timing: Verify that triggering the hook at pages:resolved instead of pages:extend does not break existing functionality or downstream processing that depends on the earlier hook point
  • Plugin/extension compatibility: Confirm whether any external plugins or extensions relying on the pages:extend hook are affected by this change
  • Test coverage: Check that existing tests for the pages module and hook system still pass with the new timing

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: moving prerender route processing to occur on the pages:resolved hook.
Description check ✅ Passed The pull request description is related to the changeset, describing the issue and the intended fix for prerendering with pages:resolved hook.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 6, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33662

nuxt

npm i https://pkg.pr.new/nuxt@33662

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33662

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33662

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33662

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33662

commit: 9b9ef2a

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025

CodSpeed Performance Report

Merging #33662 will not alter performance

Comparing BobbieGoede:fix/process-prerender-routes-on-pages-resolved (9b9ef2a) with main (6b6ea5f)

Summary

✅ 10 untouched

@danielroe danielroe merged commit 0014826 into nuxt:main Nov 6, 2025
56 of 57 checks passed
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
@github-actions github-actions bot mentioned this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prerender 404 error if initial route has custom path

2 participants