fix(nitro): use directory paths in `moduleEntryPaths` #33628

cernymatej · 2025-11-01T20:04:43Z

📚 Description

This fixes an issue where the generated tsconfig paths in

Lines 211 to 215 in 89f59b7

    
           const moduleDir = relativeWithDot(nuxt.options.buildDir, m) 
        
           return [ 
        
             join(moduleDir, 'runtime/server'), 
        
             join(moduleDir, 'dist/runtime/server'), 
        
           ]

were incorrect in some cases: (notice the index.ts there)

I matched the implementation with:

nuxt/packages/kit/src/template.ts

Lines 295 to 301 in 89f59b7

    
           const moduleEntryPaths: string[] = [] 
        
           for (const m of nuxt.options._installedModules) { 
        
             const path = m.meta?.rawPath || m.entryPath 
        
             if (path) { 
        
               moduleEntryPaths.push(getDirectory(path)) 
        
             } 
        
           }

bolt-new-by-stackblitz · 2025-11-01T20:04:46Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-11-01T20:08:01Z

Walkthrough

The changes modify the Nitro bundle logic in the nitro-server package. The import statement is updated to include getDirectory from @nuxt/kit alongside the existing getLayerDirectories. Subsequently, the code that collects module entry paths is modified to process each path through the getDirectory function before adding it to the moduleEntryPaths array, replacing the previous direct path assignment.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Verify that getDirectory is correctly imported and available from @nuxt/kit
Confirm that getDirectory(path) produces the intended output format for module entry paths and is compatible with downstream consumers of moduleEntryPaths
Ensure the change does not inadvertently alter the module resolution logic or break module loading functionality

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	The pull request description is clearly related to the changeset. It explains the issue being fixed—that generated tsconfig paths in packages/nitro-server/src/index.ts were incorrect, including file paths (e.g., `index.ts`) instead of directory paths—and references the specific code location and a related implementation for alignment. The description provides sufficient context about why this change was needed, making it directly relevant to the modifications in the changeset.
Title Check	✅ Passed	The pull request title "fix(nitro): use directory paths in `moduleEntryPaths`" directly and accurately summarizes the main change in the changeset. The modification replaces raw path values with `getDirectory(path)` when populating `moduleEntryPaths`, which aligns precisely with the PR's objective to produce directory-based module entry paths for tsconfig generation instead of explicit file paths. The title is concise, specific, and clearly identifies both the component being modified and the nature of the fix, making it easy for reviewers to understand the primary intent.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2025-11-01T20:08:37Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33628

nuxt

npm i https://pkg.pr.new/nuxt@33628

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33628

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33628

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33628

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33628

commit: fd76b36

codspeed-hq · 2025-11-01T20:16:23Z

CodSpeed Performance Report

Merging #33628 will not alter performance

_{Comparing cernymatej:fix/nitro-module-entry-paths (fd76b36) with main (89f59b7)}

Summary

✅ 10 untouched

danielroe

thank you ❤️

fix(nuxt): use directory paths in moduleEntryPaths

fd76b36

cernymatej requested a review from danielroe as a code owner November 1, 2025 20:04

github-actions bot added 4.x bug labels Nov 1, 2025

danielroe changed the title ~~fix(nuxt): use directory paths in moduleEntryPaths~~ fix(nitro): use directory paths in moduleEntryPaths Nov 1, 2025

danielroe approved these changes Nov 3, 2025

View reviewed changes

danielroe merged commit 2f984b9 into nuxt:main Nov 3, 2025
101 of 102 checks passed

github-actions bot mentioned this pull request Nov 3, 2025

v4.2.1 #33565

Merged

cernymatej deleted the fix/nitro-module-entry-paths branch November 3, 2025 13:56

danielroe pushed a commit that referenced this pull request Nov 6, 2025

fix(nitro): use directory paths in moduleEntryPaths (#33628)

ec72b60

github-actions bot mentioned this pull request Nov 6, 2025

v3.20.1 #33649

Merged

coderabbitai bot mentioned this pull request Dec 11, 2025

tsconfig.server.json has wrong alias for ~ #33853

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(nitro): use directory paths in `moduleEntryPaths` #33628

fix(nitro): use directory paths in `moduleEntryPaths` #33628

Uh oh!

cernymatej commented Nov 1, 2025

Uh oh!

bolt-new-by-stackblitz bot commented Nov 1, 2025

Uh oh!

coderabbitai bot commented Nov 1, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Nov 1, 2025

Uh oh!

codspeed-hq bot commented Nov 1, 2025

Uh oh!

danielroe left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const moduleDir = relativeWithDot(nuxt.options.buildDir, m)
	return [
	join(moduleDir, 'runtime/server'),
	join(moduleDir, 'dist/runtime/server'),
	]

	const moduleEntryPaths: string[] = []
	for (const m of nuxt.options._installedModules) {
	const path = m.meta?.rawPath \|\| m.entryPath
	if (path) {
	moduleEntryPaths.push(getDirectory(path))
	}
	}

Uh oh!

fix(nitro): use directory paths in moduleEntryPaths #33628

fix(nitro): use directory paths in moduleEntryPaths #33628

Uh oh!

Conversation

cernymatej commented Nov 1, 2025

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Nov 1, 2025

Uh oh!

coderabbitai bot commented Nov 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

pkg-pr-new bot commented Nov 1, 2025

Uh oh!

codspeed-hq bot commented Nov 1, 2025

CodSpeed Performance Report

Merging #33628 will not alter performance

Summary

Uh oh!

danielroe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(nitro): use directory paths in `moduleEntryPaths` #33628

fix(nitro): use directory paths in `moduleEntryPaths` #33628

coderabbitai bot commented Nov 1, 2025 •

edited

Loading