Skip to content

chore: remove vue-demi from ignoredBuiltDependencies #33494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 2 commits into from
Oct 16, 2025
Merged

chore: remove vue-demi from ignoredBuiltDependencies #33494

danielroe merged 2 commits into from
Oct 16, 2025

Conversation

@KazariEX
Copy link
Member

@KazariEX KazariEX commented Oct 16, 2025

No description provided.

@KazariEX KazariEX requested a review from danielroe as a code owner October 16, 2025 11:00
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 16, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Oct 16, 2025 •
edited
Loading

Walkthrough

This change updates the pnpm-workspace.yaml file by removing the vue-demi entry from the ignoredBuiltDependencies list. No other top-level keys (such as publicHoistPattern) or entries were modified, and there are no changes to control flow, error handling, exported or public entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description Check ❓ Inconclusive The pull request contains no description provided by the author. Whilst the check is described as lenient and only requires that the description be related to the changeset in some way, the complete absence of a description makes it impossible to assess whether it contains any information related to the changeset. This represents insufficient information to conclusively determine whether the check would pass or fail under the stated criteria. The author should consider adding a brief description explaining the rationale for removing vue-demi from ignoredBuiltDependencies. Even a short sentence describing the motivation or impact of this change would provide valuable context for reviewers and future maintainers examining the pull request history.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "chore: remove vue-demi from ignoredBuiltDependencies" directly and accurately reflects the main change in the changeset. According to the raw summary, the only modification made to pnpm-workspace.yaml is the removal of vue-demi from the ignoredBuiltDependencies list. The title is concise, specific, and clearly communicates the primary change without unnecessary noise or vague terminology.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fee7cfc and 7b8ffbb.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml (0 hunks)
💤 Files with no reviewable changes (1)
  • pnpm-workspace.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (20)
  • GitHub Check: test-fixtures (windows-latest, built, rspack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, rspack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, webpack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, dev, vite, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, rspack, async, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-on, js, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, dev, vite, async, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, dev, vite, default, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-on, js, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-off, json, lts/-1)
  • GitHub Check: release-pkg-pr-new
  • GitHub Check: test-size
  • GitHub Check: test-benchmark
  • GitHub Check: typecheck (windows-latest, bundler)
  • GitHub Check: typecheck (ubuntu-latest, bundler)
  • GitHub Check: code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitai bot reviewed Oct 16, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7bcc4ca and fee7cfc.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: test-fixtures (windows-latest, built, webpack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, webpack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, built, vite, async, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, dev, vite, async, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (windows-latest, built, rspack, async, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, rspack, async, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, rspack, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, default, manifest-on, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, built, vite, async, manifest-on, js, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, dev, vite, default, manifest-off, json, lts/-1)
  • GitHub Check: test-fixtures (ubuntu-latest, dev, vite, async, manifest-on, json, lts/-1)
  • GitHub Check: test-benchmark
  • GitHub Check: release-pkg-pr-new
  • GitHub Check: typecheck (ubuntu-latest, bundler)
  • GitHub Check: typecheck (windows-latest, bundler)
  • GitHub Check: test-size
  • GitHub Check: code

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 16, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33494

nuxt

npm i https://pkg.pr.new/nuxt@33494

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33494

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33494

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33494

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33494

commit: 7b8ffbb

danielroe
danielroe reviewed Oct 16, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were intentionally skipping the build step of these packages as it wasn't necessary for this repo

did you encounter an issue?

@KazariEX
Copy link
Member Author

KazariEX commented Oct 16, 2025 •
edited
Loading

If we think about it this way, do we not need to set ignoredBuiltDependencies? It would not run any build steps by default.

Or is this to prevent the installation script from displaying the unbuilt prompt every time?

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 16, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #33494 will not alter performance

Comparing KazariEX:chore/only-built-dependencies (7b8ffbb) with main (7bcc4ca)

Summary

✅ 10 untouched

@KazariEX KazariEX changed the title chore: use onlyBuiltDependencies instead of ignoredBuiltDependencies chore: remove vue-demi from ignoredBuiltDependencies Oct 16, 2025
@danielroe
Copy link
Member

danielroe commented Oct 16, 2025

exactly.

and we don't import from vue-demi so I think it's safe not to run its install script

@KazariEX
Copy link
Member Author

KazariEX commented Oct 16, 2025 •
edited
Loading

vue-demi no longer exists in the lockfile.

@danielroe danielroe merged commit 84b82c4 into nuxt:main Oct 16, 2025
48 checks passed
@github-actions github-actions bot mentioned this pull request Oct 16, 2025
Merged
@KazariEX KazariEX deleted the chore/only-built-dependencies branch October 18, 2025 08:53
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Closed
danielroe pushed a commit that referenced this pull request Oct 25, 2025
@KazariEX @danielroe
chore: remove vue-demi from ignoredBuiltDependencies (#33494)
4fc968a
@github-actions github-actions bot mentioned this pull request Oct 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees

No one assigned

Labels

4.x chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KazariEX @danielroe