fix(kit): safe assignment and cleanup of `defineNuxtConfig` for concurrent calls #33420

KazariEX · 2025-10-07T13:25:52Z

🔗 Linked issue

📚 Description

To avoid errors like #33410 from happening again, we need to ensure that the call to loadNuxtConfig is concurrency-safe.

… calls

bolt-new-by-stackblitz · 2025-10-07T13:25:56Z

Run & review this pull request in StackBlitz Codeflow.

coderabbitai · 2025-10-07T13:29:14Z

Warning

Rate limit exceeded

@KazariEX has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 22 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 659ede4 and a897780.

📒 Files selected for processing (1)

packages/kit/src/loader/config.ts (2 hunks)

Walkthrough

Introduces a new internal helper, withDefineNuxtConfig, that scopes exposure of globalThis.defineNuxtConfig using a per-process reference counter. The previous pattern of assigning globalThis.defineNuxtConfig immediately before calling loadConfig and deleting it after is removed. loadConfig calls are now wrapped with withDefineNuxtConfig so the global is available for the duration of the scoped call and cleaned up when the last consumer finishes. No exported or public API signatures were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly captures the primary change by describing the safe assignment and cleanup of `defineNuxtConfig` for concurrent calls, directly reflecting the main update introduced in the code. It is clear, specific, and immediately conveys the intent of the fix.
Description Check	✅ Passed	The description clearly relates to the changes by stating the goal of preventing errors like #33410 through making the `loadNuxtConfig` call concurrency-safe, which aligns with the code modifications.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5589a44 and a269d98.

📒 Files selected for processing (1)

packages/kit/src/loader/config.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Follow standard TypeScript conventions and best practices

Files:

packages/kit/src/loader/config.ts

🔇 Additional comments (1)

packages/kit/src/loader/config.ts (1)

36-48: LGTM!

The wrapping of loadConfig with withDefineNuxtConfig correctly preserves the original behaviour while adding the reference-counted lifecycle management for globalThis.defineNuxtConfig.

packages/kit/src/loader/config.ts

pkg-pr-new · 2025-10-07T13:41:24Z

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33420

nuxt

npm i https://pkg.pr.new/nuxt@33420

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33420

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33420

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33420

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33420

commit: a897780

codspeed-hq · 2025-10-07T13:48:49Z

CodSpeed Performance Report

Merging #33420 will not alter performance

_{Comparing KazariEX:fix/define-nuxt-config-count (a897780) with main (5589a44)}

Summary

✅ 10 untouched

packages/kit/src/loader/config.ts

danielroe · 2025-10-07T18:49:15Z

thank you ❤️

fix: safe assignment and cleanup of defineNuxtConfig for concurrent…

a269d98

… calls

KazariEX requested a review from danielroe as a code owner October 7, 2025 13:25

github-actions bot added 4.x bug labels Oct 7, 2025

coderabbitai bot reviewed Oct 7, 2025

View reviewed changes

packages/kit/src/loader/config.ts Outdated Show resolved Hide resolved

fix: use finally

d3263a9

danielroe reviewed Oct 7, 2025

View reviewed changes

packages/kit/src/loader/config.ts Outdated Show resolved Hide resolved

KazariEX added 4 commits October 7, 2025 22:44

fix: use global variable to track count

7d7f559

fix: cleanup

659ede4

refactor: put count on defineNuxtConfig

cb65937

refactor: simplify

a897780

danielroe approved these changes Oct 7, 2025

View reviewed changes

danielroe merged commit 94e6fbb into nuxt:main Oct 7, 2025
83 of 84 checks passed

github-actions bot mentioned this pull request Oct 7, 2025

v4.1.4 #33408

Closed

KazariEX deleted the fix/define-nuxt-config-count branch October 7, 2025 18:50

github-actions bot mentioned this pull request Oct 7, 2025

v4.2.0 #33425

Merged

github-actions bot mentioned this pull request Oct 23, 2025

v5.0.0 #33548

Closed

danielroe pushed a commit that referenced this pull request Oct 25, 2025

fix(kit): safely cleanup loadNuxtConfig in concurrent calls (#33420)

a0771b7

github-actions bot mentioned this pull request Oct 25, 2025

v3.20.0 #33566

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(kit): safe assignment and cleanup of `defineNuxtConfig` for concurrent calls #33420

fix(kit): safe assignment and cleanup of `defineNuxtConfig` for concurrent calls #33420

Uh oh!

KazariEX commented Oct 7, 2025 •

edited

Loading

Uh oh!

bolt-new-by-stackblitz bot commented Oct 7, 2025

Uh oh!

coderabbitai bot commented Oct 7, 2025 •

edited

Loading

Rate limit exceeded

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

codspeed-hq bot commented Oct 7, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

danielroe commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(kit): safe assignment and cleanup of defineNuxtConfig for concurrent calls #33420

fix(kit): safe assignment and cleanup of defineNuxtConfig for concurrent calls #33420

Uh oh!

Conversation

KazariEX commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Linked issue

📚 Description

Uh oh!

bolt-new-by-stackblitz bot commented Oct 7, 2025

Uh oh!

coderabbitai bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Estimated code review effort

Pre-merge checks and finishing touches

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-new bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #33420 will not alter performance

Summary

Uh oh!

Uh oh!

Uh oh!

danielroe commented Oct 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(kit): safe assignment and cleanup of `defineNuxtConfig` for concurrent calls #33420

fix(kit): safe assignment and cleanup of `defineNuxtConfig` for concurrent calls #33420

KazariEX commented Oct 7, 2025 •

edited

Loading

coderabbitai bot commented Oct 7, 2025 •

edited

Loading

pkg-pr-new bot commented Oct 7, 2025 •

edited

Loading

codspeed-hq bot commented Oct 7, 2025 •

edited

Loading