Skip to content

refactor(nuxt): place filename into componentsIslandsTemplate definition #33394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 1 commit into from
Oct 5, 2025
Merged

refactor(nuxt): place filename into componentsIslandsTemplate definition #33394

danielroe merged 1 commit into from
Oct 5, 2025

Conversation

@KazariEX
Copy link
Member

@KazariEX KazariEX commented Oct 5, 2025

🔗 Linked issue

📚 Description

Looks like this is some legacy code that can be simplified.

@KazariEX KazariEX requested a review from danielroe as a code owner October 5, 2025 18:37
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Oct 5, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Oct 5, 2025

Walkthrough

The change updates how the components islands template is registered and defined. In module.ts, addTemplate is now called with the template object directly instead of spreading it and overriding the filename. In templates.ts, the componentsIslandsTemplate explicitly includes filename: 'components.islands.mjs'. No other logic, control flow, or exported APIs are altered.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately summarises the primary change by stating the refactor in Nuxt to move the filename into the template definition of componentsIslandsTemplate, matching the modifications described in the changeset.
Description Check ✅ Passed The description indicates that legacy code is being simplified, which aligns with the refactoring objective in the changeset even though it is brief and lacks technical detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 399df6b and 1a3d87e.

📒 Files selected for processing (2)
  • packages/nuxt/src/components/module.ts (1 hunks)
  • packages/nuxt/src/components/templates.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Follow standard TypeScript conventions and best practices

Files:

  • packages/nuxt/src/components/templates.ts
  • packages/nuxt/src/components/module.ts
🧬 Code graph analysis (1)
packages/nuxt/src/components/module.ts (2)
packages/kit/src/template.ts (1)
  • addTemplate (24-50)
packages/nuxt/src/components/templates.ts (1)
  • componentsIslandsTemplate (78-110)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build
  • GitHub Check: code
🔇 Additional comments (2)
packages/nuxt/src/components/templates.ts (1)

79-79: LGTM! Improves consistency.

Adding the explicit filename property aligns this template with other templates in the file (e.g., componentsPluginTemplate at line 29, componentNamesTemplate at line 66) and eliminates the need for overriding it at the call site.

packages/nuxt/src/components/module.ts (1)

135-135: LGTM! Simplifies template registration.

Removing the spread operator and filename override is appropriate now that componentsIslandsTemplate includes its own filename property. This simplifies the code and eliminates duplication.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 5, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33394

nuxt

npm i https://pkg.pr.new/nuxt@33394

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33394

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33394

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33394

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33394

commit: 1a3d87e

@danielroe danielroe merged commit 13452a2 into nuxt:main Oct 5, 2025
45 of 47 checks passed
@github-actions github-actions bot mentioned this pull request Oct 4, 2025
Merged
@KazariEX KazariEX deleted the refactor/islands-template-filename branch October 6, 2025 05:09
danielroe pushed a commit that referenced this pull request Oct 6, 2025
@KazariEX @danielroe
refactor(nuxt): place filename into componentsIslandsTemplate def…
d5f6457 
…inition (#33394)
@github-actions github-actions bot mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KazariEX @danielroe