Skip to content

fix(nuxt): remove mergeModels from auto imports #33344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 3 commits into from
Oct 7, 2025
Merged

fix(nuxt): remove mergeModels from auto imports #33344

danielroe merged 3 commits into from
Oct 7, 2025
+1 −1

Conversation

@KazariEX
Copy link
Member

@KazariEX KazariEX commented Sep 28, 2025

@KazariEX KazariEX requested a review from danielroe as a code owner September 28, 2025 15:08
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 28, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@KazariEX KazariEX changed the title chore(nuxt): remove mergeModels from auto imports fix(nuxt): remove mergeModels from auto imports Sep 28, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 28, 2025 •
edited
Loading

Walkthrough

Removed the mergeModels import from the vuePreset imports list in packages/nuxt/src/imports/presets.ts. Correspondingly, tests were updated: mergeModels was added to the excludedVueHelpers array in packages/nuxt/test/auto-imports.test.ts. No other presets, control flow, exports, or public declarations were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly summarises the primary change by stating that mergeModels has been removed from Nuxt’s auto imports. It follows conventional commit style with a fix(nuxt) prefix and clearly indicates the behavioural fix. It is concise and specific without extraneous detail, making it easily understandable in the project history.
Description Check ✅ Passed The description directly explains that mergeModels is an internal API and should not be auto imported, aligning with the changeset. It references the relevant source code location in Vue core to provide context. The detail is succinct yet on-topic and clearly conveys the rationale for the change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5195d85 and 2a86fd9.

📒 Files selected for processing (2)
  • packages/nuxt/src/imports/presets.ts (0 hunks)
  • packages/nuxt/test/auto-imports.test.ts (1 hunks)
💤 Files with no reviewable changes (1)
  • packages/nuxt/src/imports/presets.ts
✅ Files skipped from review due to trivial changes (1)
  • packages/nuxt/test/auto-imports.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 28, 2025 •
edited
Loading

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33344

nuxt

npm i https://pkg.pr.new/nuxt@33344

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33344

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33344

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33344

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33344

commit: 2a86fd9

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #33344 will not alter performance

Comparing KazariEX:chore/remove-internal-auto-import (2a86fd9) with main (94e6fbb)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on main (7f48766) during the generation of this report, so 94e6fbb was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

danielroe
danielroe approved these changes Oct 7, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@danielroe danielroe merged commit 9ad3578 into nuxt:main Oct 7, 2025
47 checks passed
@KazariEX KazariEX deleted the chore/remove-internal-auto-import branch October 7, 2025 19:54
@github-actions github-actions bot mentioned this pull request Oct 7, 2025
Merged
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
Closed
danielroe pushed a commit that referenced this pull request Oct 25, 2025
@KazariEX @danielroe
fix(nuxt): remove mergeModels from auto imports (#33344)
7c12330
@github-actions github-actions bot mentioned this pull request Oct 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KazariEX @danielroe