Skip to content

Conversation

@KazariEX
Copy link
Member

@KazariEX KazariEX commented Sep 28, 2025

🔗 Linked issue

📚 Description

before after
image image

@KazariEX KazariEX requested a review from danielroe as a code owner September 28, 2025 10:49
@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@coderabbitai
Copy link

coderabbitai bot commented Sep 28, 2025

Walkthrough

The change updates formatting in packages/nuxt/src/components/templates.ts for generated TypeScript declaration templates. Indentation within the _GlobalComponents interface entries and their Lazy counterparts is reduced from four spaces to two spaces in both the template used for type generation and the components.d.ts template. There are no changes to type names, exports, or signatures; only whitespace/indentation is modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title “chore(nuxt): align global components indent” accurately and concisely summarises the primary change of adjusting indentation for global components declarations, follows conventional commit format, and will be clear to teammates reviewing history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description includes before-and-after visual comparisons of the indentation adjustment, which directly corresponds to the formatting changes made in the components template and is therefore related to the changeset.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 28, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33340

nuxt

npm i https://pkg.pr.new/nuxt@33340

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33340

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33340

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33340

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33340

commit: 116c15b

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 28, 2025

CodSpeed Performance Report

Merging #33340 will not alter performance

Comparing KazariEX:chore/global-components-indent (116c15b) with main (107197b)

Summary

✅ 10 untouched

@danielroe danielroe merged commit 57a965f into nuxt:main Sep 28, 2025
85 of 87 checks passed
@github-actions github-actions bot mentioned this pull request Sep 28, 2025
@KazariEX KazariEX deleted the chore/global-components-indent branch September 28, 2025 12:42
@github-actions github-actions bot mentioned this pull request Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants