-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
docs: update app config paths to use app/app.config.ts #33297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
thank you ! |
WalkthroughDocumentation updates only: multiple references and code fence annotations were changed from app.config.ts to app/app.config.ts in two docs pages. Code block labels and inline path mentions were adjusted to reflect the app config file residing under the app/ subdirectory. No runtime code, logic, or API changes. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/2.guide/2.directory-structure/1.app/3.app-config.md (1)
8-8: Tighten copy for clarity and casingProposed wording improves grammar and uses “Nuxt plugin” casing.
-Nuxt provides an `app/app.config.ts` config file to expose reactive configuration within your application with the ability to update it at runtime within lifecycle or using a nuxt plugin and editing it with HMR (hot-module-replacement). +Nuxt provides an `app/app.config.ts` file to expose reactive configuration. You can update it at runtime within lifecycle hooks or via a Nuxt plugin, and edit it with HMR (hot module replacement).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/1.getting-started/03.configuration.md(1 hunks)docs/2.guide/2.directory-structure/1.app/3.app-config.md(3 hunks)
🔇 Additional comments (5)
docs/2.guide/2.directory-structure/1.app/3.app-config.md (4)
12-16: Fence label path looks right
[app/app.config.ts]aligns with the new location.
30-36: Consistent path in usage exampleGood consistency with the earlier example.
136-141: Project override example uses new pathLooks good and consistent with the layer example above.
129-134: Approve — layer example updated correctlyNo remaining occurrences of
layer/app.config.tsfound; only docs/2.guide/2.directory-structure/1.app/3.app-config.md:129 containslayer/app/app.config.ts.docs/1.getting-started/03.configuration.md (1)
107-117: Update remaining inlineapp.config.tsreferences toapp/app.config.tsFound inline references that still use
app.config.ts; update them or confirm they're intentionally unprefixed:
- docs/2.guide/2.directory-structure/1.app/3.app-config.md — lines 10, 147, 149
- docs/1.getting-started/03.configuration.md — line 103
- docs/1.getting-started/18.upgrade.md — line 171
🔗 Linked issue
-
📚 Description
Updated the paths to
app.config.tsin accordance with the newapp/directory.