Skip to content

refactor(nuxt): resolve path of typed-router.d.ts early for consistency #33285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 1 commit into from
Sep 23, 2025
Merged

refactor(nuxt): resolve path of typed-router.d.ts early for consistency #33285

danielroe merged 1 commit into from
Sep 23, 2025

Conversation

@KazariEX
Copy link
Member

@KazariEX KazariEX commented Sep 21, 2025 •
edited
Loading

🔗 Linked issue

📚 Description

Ensure that the path of typed-router.d.ts passed to references are absolute to reduce implicit coupling, while also allowing generate relative paths without the ./ prefix into nuxt.d.ts, keeping it consistent with other entries.

@KazariEX KazariEX requested a review from danielroe as a code owner September 21, 2025 17:08
@bolt-new-by-stackblitz
Copy link

bolt-new-by-stackblitz bot commented Sep 21, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 21, 2025

Open in StackBlitz

@nuxt/kit

npm i https://pkg.pr.new/@nuxt/kit@33285

nuxt

npm i https://pkg.pr.new/nuxt@33285

@nuxt/rspack-builder

npm i https://pkg.pr.new/@nuxt/rspack-builder@33285

@nuxt/schema

npm i https://pkg.pr.new/@nuxt/schema@33285

@nuxt/vite-builder

npm i https://pkg.pr.new/@nuxt/vite-builder@33285

@nuxt/webpack-builder

npm i https://pkg.pr.new/@nuxt/webpack-builder@33285

commit: 6e2a4c3

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 21, 2025

CodSpeed Performance Report

Merging #33285 will not alter performance

Comparing KazariEX:refactor/resolve-typed-router (6e2a4c3) with main (dc69e26)1

Summary

✅ 10 untouched

Footnotes

  1. No successful run was found on main (78d45c1) during the generation of this report, so dc69e26 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@danielroe danielroe merged commit c791676 into nuxt:main Sep 23, 2025
45 of 48 checks passed
@github-actions github-actions bot mentioned this pull request Sep 23, 2025
Merged
@KazariEX KazariEX deleted the refactor/resolve-typed-router branch September 23, 2025 09:54
danielroe pushed a commit that referenced this pull request Oct 6, 2025
@KazariEX @danielroe
refactor(nuxt): resolve path of typed-router.d.ts early for consist…
5aa25c5 
…ency (#33285)
@github-actions github-actions bot mentioned this pull request Oct 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

4.x refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KazariEX @danielroe