feat(kit,nuxt,schema,vite,webpack): migrate to nitropack v3 nightly#27702
Merged
feat(kit,nuxt,schema,vite,webpack): migrate to nitropack v3 nightly#27702
Conversation
|
|
danielroe
changed the title
danielroe
commented
Jun 19, 2024
Member
Author
|
/trigger release |
pi0
reviewed
Jun 20, 2024
pi0
reviewed
Jun 20, 2024
pi0
reviewed
Jun 20, 2024
| } | ||
| if (ctx.isClient) { | ||
| ctx.alias['#internal/nitro'] = resolve(ctx.nuxt.options.buildDir, 'nitro.client.mjs') | ||
| ctx.alias['nitro/runtime'] = resolve(ctx.nuxt.options.buildDir, 'nitro.client.mjs') |
Member
There was a problem hiding this comment.
Just checking it was because of runtime config access right?
Member
Author
There was a problem hiding this comment.
Exactly. This is so we can use isomorphic code that gets replaced with different runtime config code on client.
Member
There was a problem hiding this comment.
Okay! I have an idea to get rid of it!
pi0
reviewed
Jun 20, 2024
| "@unhead/dom", | ||
| "@unhead/shared", | ||
| "@unhead/ssr", | ||
| "db0", |
Member
There was a problem hiding this comment.
It shouldn't be added by default in the prod bundle seems strange!
pi0
reviewed
Jun 20, 2024
8 tasks
This was referenced Jun 26, 2024
Merged
Kamsou
pushed a commit
to Kamsou/nuxt
that referenced
this pull request
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
📚 Description
This migrates to a particular version of nitro v3 and h3 v2 nightly releases, for further testing.
nitrorather thannitropack(at least internally)nitro/typesandnitropack/typesMore significant breaking changes are coming in
h3, along with the following further todosevent.node