Skip to content

feat(schema): default to bundler module resolution#22821

Merged
danielroe merged 4 commits intomainfrom
feat/default-bundler-resolution
Dec 19, 2023
Merged

feat(schema): default to bundler module resolution#22821
danielroe merged 4 commits intomainfrom
feat/default-bundler-resolution

Conversation

@danielroe
Copy link
Copy Markdown
Member

@danielroe danielroe commented Aug 25, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This opts us in to TypeScript bundler resolution which should more closely resemble the actual way that we resolve subpath imports for modules in Nuxt projects.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe self-assigned this Aug 25, 2023
@bolt-new-by-stackblitz
Copy link
Copy Markdown

bolt-new-by-stackblitz bot commented Aug 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe
Copy link
Copy Markdown
Member Author

danielroe commented Aug 25, 2023

/ecosystem-ci run

@nuxt-ecosystem-ci
Copy link
Copy Markdown

nuxt-ecosystem-ci bot commented Aug 25, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
starter ✅ success
content ❌ failure
image ❌ failure
pinia ✅ success
examples ✅ success
bridge ✅ success
nuxt-vitest ✅ success
vite-pwa ✅ success
docus ✅ success
og-image ❌ failure
histoire ✅ success
elk ❌ failure
devtools ✅ success
module-builder ✅ success
sanity-module ❌ failure
i18n-module ✅ success

@danielroe danielroe added this to the 3.8 milestone Sep 11, 2023
@danielroe danielroe marked this pull request as ready for review September 11, 2023 11:03
@danielroe
Copy link
Copy Markdown
Member Author

danielroe commented Sep 28, 2023

/ecosystem-ci run sanity-module

@nuxt-ecosystem-ci
Copy link
Copy Markdown

nuxt-ecosystem-ci bot commented Sep 28, 2023 •
edited
Loading

📝 Ran ecosystem CI: Open

suite result
sanity-module ❌ failure

@danielroe danielroe modified the milestones: 3.8, 3.9 Oct 24, 2023
@danielroe
Copy link
Copy Markdown
Member Author

danielroe commented Nov 23, 2023

/ecosystem-ci run

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@be11bac). Click here to learn what that means.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #22821   +/-   ##
=======================================
  Coverage        ?   58.76%           
=======================================
  Files           ?        5           
  Lines           ?      861           
  Branches        ?       46           
=======================================
  Hits            ?      506           
  Misses          ?      355           
  Partials        ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nuxt-ecosystem-ci
Copy link
Copy Markdown

nuxt-ecosystem-ci bot commented Nov 23, 2023

📝 Ran ecosystem CI on ea1c524: Open

suite result latest scheduled
starter ✅ success ✅ success
content ❌ failure ✅ success
ui ❌ failure ❌ failure
image ✅ success ✅ success
pinia ✅ success ✅ success
examples ✅ success ✅ success
bridge ✅ success ✅ success
nuxt-vitest ✅ success ✅ success
nuxt-com ❌ failure ✅ success
vite-pwa ✅ success ✅ success
docus ✅ success ✅ success
og-image ✅ success ✅ success
histoire ❌ failure ❌ failure
elk ❌ failure ✅ success
devtools ✅ success ✅ success
module-builder ✅ success ✅ success
sanity-module ✅ success ✅ success
i18n-module ✅ success ✅ success

@danielroe danielroe mentioned this pull request Dec 19, 2023
Closed
2 tasks
@danielroe danielroe merged commit 8f5fed5 into main Dec 19, 2023
@danielroe danielroe deleted the feat/default-bundler-resolution branch December 19, 2023 15:02
@github-actions github-actions bot mentioned this pull request Dec 19, 2023
Merged
danielroe added a commit that referenced this pull request Dec 20, 2023
@danielroe
feat(schema): default to bundler module resolution (#22821)
9d508b0
@danielroe danielroe mentioned this pull request Dec 20, 2023
Merged
8 tasks
danielroe added a commit that referenced this pull request Jan 2, 2024
@danielroe
feat(schema): default to bundler module resolution (#22821)
bdf8dcc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danielroe danielroe

Labels

3.x enhancement schema

Projects

None yet

Milestone

3.9

Development

Successfully merging this pull request may close these issues.

2 participants

@danielroe @codecov-commenter