Skip to content

feat(nuxt): add chokidar watcher debug timing#20176

Merged
danielroe merged 1 commit intonuxt:mainfrom
stafyniaksacha:chokidar-timing
Apr 11, 2023
Merged

feat(nuxt): add chokidar watcher debug timing#20176
danielroe merged 1 commit intonuxt:mainfrom
stafyniaksacha:chokidar-timing

Conversation

@stafyniaksacha
Copy link
Copy Markdown
Contributor

@stafyniaksacha stafyniaksacha commented Apr 10, 2023

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I have noticed that chokidar take a lot of time during initialization (can take more than 30sec). I'm adding measurement here, so we can have a reference for further optimization.

Chokidar will recursively discover all subdirectories/files (node_modules / .git / ...), regardless ignored option (which is used only to filter events send).

I think it's a wanted behavior, to ensure consistency
https://github.com/paulmillr/chokidar/blob/0f163b89f3ae76607900aa48fec9fa3fdefd7ca1/lib/fsevents-handler.js#L455-L457

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Apr 10, 2023

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@danielroe danielroe changed the title chore: add chokidar watcher debug timing feat(nuxt): add chokidar watcher debug timing Apr 11, 2023
@danielroe danielroe merged commit 811bf28 into nuxt:main Apr 11, 2023
@danielroe danielroe mentioned this pull request Apr 11, 2023
@stafyniaksacha stafyniaksacha deleted the chokidar-timing branch April 11, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants