Skip to content

fix(nuxt-img): add appropriate crossorigin attribute to preload link #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielroe merged 3 commits into from
Oct 28, 2025
Merged

fix(nuxt-img): add appropriate crossorigin attribute to preload link #1836

danielroe merged 3 commits into from
Oct 28, 2025

Conversation

@sotasan
Copy link
Contributor

@sotasan sotasan commented May 11, 2025

🔗 Linked issue

Resolves #1835

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

It fixes the following Chrome warning when setting a crossorigin attribute for external images:

A preload for 'XXX' is found, but is not used because the request credentials mode does not match.
Consider taking a look at crossorigin attribute.

@sotasan sotasan requested a review from danielroe as a code owner May 11, 2025 18:42
@pkg-pr-new
Copy link

pkg-pr-new bot commented May 11, 2025 •
edited
Loading

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@1836

commit: cc15678

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.03%. Comparing base (7efb6ef) to head (cc15678).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##            main   #1836      +/-   ##
========================================
- Coverage   7.03%   7.03%   -0.01%     
========================================
  Files         77      77              
  Lines       3552    3553       +1     
  Branches     138     138              
========================================
  Hits         250     250              
- Misses      3254    3255       +1     
  Partials      48      48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe changed the title feat: automatically add crossorigin attribute to preload link fix(nuxt-img): add appropriate crossorigin attribute to preload link Oct 28, 2025
danielroe
danielroe approved these changes Oct 28, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! ❤️

my apologies for the long delay on this.

@danielroe danielroe merged commit bf778b5 into nuxt:main Oct 28, 2025
7 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2025
Merged
@github-actions github-actions bot mentioned this pull request Nov 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielroe danielroe danielroe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Preload add crossorigin attribute

3 participants

@sotasan @codecov-commenter @danielroe