fix(cloudflare): don't add baseURL if no operations #1790
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying nuxt-image with
|
| Latest commit: |
1a5786c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d608ebb1.nuxt-image.pages.dev |
| Branch Preview URL: | https://fix-cloudflare-baseurl.nuxt-image.pages.dev |
danielroe
approved these changes
Apr 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1790 +/- ##
=======================================
Coverage 63.01% 63.01%
=======================================
Files 80 80
Lines 3742 3742
Branches 426 426
=======================================
Hits 2358 2358
Misses 1356 1356
Partials 28 28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 3, 2025
Closed
Closed
Closed
Merged
danielroe
pushed a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Should resolves #1080
❓ Type of change
📚 Description
Using Cloudflare means setting the baseURL as a domain.
But if no modifiers/operations are set, it will join the urls, making it fail when the source is an absolute url.