Skip to content

Missing fit modes on cloudinary provider, and existing ones are wrongly mapped  #1354

@ptdev

Description

@ptdev

Hey,

The cloudinary provider is missing some fit modes that are supported by Cloudinary.

Specifically, I was looking to use the "lfill" mode, which as far as I can see, is the equivalent to the "cover" mode in nuxt-image.

But after looking into the source code, nuxt-image is apparently mapping the "cover" mode with cloudinary's "fit" mode which are not equivalent.

According to nuxt-image docs, the "cover" mode states:

Preserving aspect ratio, ensure the image covers both provided dimensions by cropping/clipping to fit

While cloudinary's "fit" mode does not crop or clip images. From their docs regarding their "fit" mode, they state:

(...) The original aspect ratio is retained and all of the original image is visible

Also, doing a test with the same image using ipx and cloudinary using default values yields different images which further confirms the mappings for the fit modes are not totally correct.

Cheers!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingenhancementNew feature or requestprovider

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions