Remove devDependencies on manual install#434
Merged
Merged
Conversation
aligning install with the `npx nuxi` command
Member
|
I am not very sure as it doesn't need to be installed as prodDeps, I am not sure why |
atinux
approved these changes
May 4, 2026
Member
|
After many thoughts, I finally think it's better to list used modules as dependencies so it's easier to catch what are the dependencies used in the website in production, even though thanks to Nitro bundling, everything could be listed as dev dependency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aligning install with the
npx nuxicommand❓ Type of change
📚 Description
npx nuxi module add iconcommand doesn't add the package asdevDependencies. This PR updates the manual installation to align the installation on both methods.