This repository was archived by the owner on Apr 6, 2023. It is now read-only.
Conversation
✅ Deploy Preview for nuxt3-docs canceled.
|
Member
|
This is a nice fix but also means we have to initialize whole renderer instance each time during development mode which is a performance overhead. Maybe we can allow manifest as function within |
pi0
added
enhancement
Member
Author
|
Yes, we will need nuxt-contrib/vue-bundle-renderer#31, we could have it in |
Member
|
Upstream PR released :) |
antfu
changed the title
pi0
reviewed
Jun 10, 2022
Co-authored-by: pooya parsa <[email protected]>
Merged
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
With the previous cache change in rc.3, the manifest is always cached without invalidation, causing FOUC and development changes never updates. This PR partially fixed it by opt-out renderer cache in development, we will still have a single FOUC on the initial request after the server starts. The root cause is that with the on-demand of vite-node, the graph is only known after rendering the route, while
vue-bundle-rendererrequires manifest before doing that. nuxt-contrib/vue-bundle-renderer#31 is required to completely fix it.❓ Type of change
📚 Description
📝 Checklist