Skip to content
This repository was archived by the owner on Apr 6, 2023. It is now read-only.

fix(vite): remove global replacement#1835

Merged
pi0 merged 1 commit intomainfrom
fix/define-global
Nov 10, 2021
Merged

fix(vite): remove global replacement#1835
pi0 merged 1 commit intomainfrom
fix/define-global

Conversation

@pi0
Copy link
Copy Markdown
Member

@pi0 pi0 commented Nov 10, 2021

🔗 Linked issue

Resolves nuxt/bridge#195, Resolves nuxt/bridge#204 Resolves nuxt/nuxt#11958

Related vitejs/vite#5616

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Remove global to globalThis replacements from vite.

Alternatives to bring the backward compatibility back:

  • Polyfill process and global in globalThis
  • Use replacement with better regex

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 10, 2021

✔️ Deploy Preview for nuxt3-docs canceled.

🔨 Explore the source changes: fc30ee0

🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/618c23f811dc72000819a194

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

2 participants