Skip to content

Commit caaee7e

Browse files
author
Hagai Barel
committed
Add initial collect unit tests
1 parent 14335d0 commit caaee7e

File tree

5 files changed

+215
-138
lines changed

5 files changed

+215
-138
lines changed

‎creds.go

-90
This file was deleted.

‎emq_exporter.go

+22-21
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,21 @@ var (
3333
"nodes": "/api/v3/nodes/%s",
3434
}
3535

36+
up = prometheus.NewGauge(prometheus.GaugeOpts{
37+
Namespace: namespace,
38+
Name: "up",
39+
Help: "Was the last scrape of EMQ successful",
40+
})
41+
42+
totalScrapes = prometheus.NewCounter(prometheus.CounterOpts{
43+
Namespace: namespace,
44+
Name: "exporter_total_scrapes",
45+
Help: "Current total scrapes.",
46+
})
47+
3648
//GitTag stands for a git tag, populated at build time
3749
GitTag string
38-
//GitCommit stands for a git commit hash populated at build time
50+
//GitCommit stands for a git commit hash, populated at build time
3951
GitCommit string
4052
)
4153

@@ -48,18 +60,7 @@ func NewExporter(c *config, timeout time.Duration) *Exporter {
4860
Timeout: timeout,
4961
},
5062
mu: &sync.Mutex{},
51-
up: prometheus.NewGauge(prometheus.GaugeOpts{
52-
Namespace: namespace,
53-
Name: "up",
54-
Help: "Was the last scrape of EMQ successful",
55-
}),
56-
totalScrapes: prometheus.NewCounter(prometheus.CounterOpts{
57-
Namespace: namespace,
58-
Name: "exporter_total_scrapes",
59-
Help: "Current total scrapes.",
60-
}),
6163
}
62-
6364
}
6465

6566
// Collect implements prometheus.Collector.
@@ -75,14 +76,14 @@ func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
7576
e.mu.Lock()
7677

7778
if err != nil {
78-
e.up.Set(0)
79+
up.Set(0)
7980
} else {
80-
e.up.Set(1)
81+
up.Set(1)
8182
}
82-
ch <- e.up
83+
ch <- up
8384

84-
e.totalScrapes.Inc()
85-
ch <- e.totalScrapes
85+
totalScrapes.Inc()
86+
ch <- totalScrapes
8687

8788
metricList := make([]metric, 0, len(e.metrics))
8889
for _, i := range e.metrics {
@@ -103,8 +104,8 @@ func (e *Exporter) Collect(ch chan<- prometheus.Metric) {
103104

104105
// Describe implements prometheus.Collector.
105106
func (e *Exporter) Describe(ch chan<- *prometheus.Desc) {
106-
ch <- e.up.Desc()
107-
ch <- e.totalScrapes.Desc()
107+
ch <- up.Desc()
108+
ch <- totalScrapes.Desc()
108109
}
109110

110111
// get the json responses from the targets map, process them and
@@ -146,7 +147,7 @@ func (e *Exporter) scrape() error {
146147
return nil
147148
}
148149

149-
//addMetric adds a metric to the exporter.Metric array
150+
//add adds a metric to the exporter.metrics array
150151
func (e *Exporter) add(fqName, help string, value float64) {
151152
//check if the metric with a given fqName exists, and update its value
152153
for _, v := range e.metrics {
@@ -166,7 +167,7 @@ func (e *Exporter) add(fqName, help string, value float64) {
166167
value: value,
167168
}
168169

169-
//append it to the metrics array
170+
//append it to the e.metrics array
170171
e.mu.Lock()
171172
e.metrics = append(e.metrics, m)
172173
e.mu.Unlock()

‎emq_exporter_test.go

+105-21
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,20 @@
11
package main
22

33
import (
4+
"io/ioutil"
45
"os"
6+
"time"
57

68
. "github.com/onsi/ginkgo"
79
. "github.com/onsi/gomega"
10+
"github.com/onsi/gomega/ghttp"
11+
"github.com/prometheus/client_golang/prometheus"
812
)
913

10-
var _ = Describe("Main", func() {
14+
var _ = Describe("Utility Functions", func() {
15+
1116
Describe("Loading credentials", func() {
17+
1218
Context("loading from env vars", func() {
1319

1420
AfterEach(func() {
@@ -149,35 +155,113 @@ var _ = Describe("Main", func() {
149155
})
150156
})
151157

152-
Describe("Utility functions", func() {
153-
Context("parsing strings", func() {
158+
Context("parsing strings", func() {
154159

155-
It("should parse a simple float", func() {
156-
s := "0.5"
160+
It("should parse a simple float", func() {
161+
s := "0.5"
157162

158-
v, err := parseString(s)
163+
v, err := parseString(s)
159164

160-
Expect(err).ShouldNot(HaveOccurred())
161-
Expect(v).Should(Equal(0.5))
162-
})
165+
Expect(err).ShouldNot(HaveOccurred())
166+
Expect(v).Should(Equal(0.5))
167+
})
163168

164-
It("should parse byte represented as string", func() {
165-
s := "123.19M"
169+
It("should parse byte represented as string", func() {
170+
s := "123.19M"
166171

167-
v, err := parseString(s)
172+
v, err := parseString(s)
168173

169-
Expect(err).ShouldNot(HaveOccurred())
170-
Expect(v).Should(Equal(1.29174077e+08))
171-
})
174+
Expect(err).ShouldNot(HaveOccurred())
175+
Expect(v).Should(Equal(1.29174077e+08))
176+
})
172177

173-
It("should fail on invalid string", func() {
174-
s := "invalid string"
178+
It("should fail on invalid string", func() {
179+
s := "invalid string"
175180

176-
v, err := parseString(s)
181+
v, err := parseString(s)
177182

178-
Expect(err).Should(HaveOccurred())
179-
Expect(v).Should(Equal(float64(0)))
180-
})
183+
Expect(err).Should(HaveOccurred())
184+
Expect(v).Should(Equal(float64(0)))
181185
})
182186
})
187+
188+
Context("creating a new metric", func() {
189+
It("should return a valid metric", func() {
190+
m := metric{
191+
kind: prometheus.GaugeValue,
192+
name: "emq_node_memory_current",
193+
help: "Current memory usage",
194+
value: 1.5533,
195+
}
196+
197+
pm, err := newMetric(m)
198+
199+
Expect(err).ToNot(HaveOccurred())
200+
Expect(pm.Desc().String()).To(Equal("Desc{fqName: \"emq_node_memory_current\", help: \"Current memory usage\", constLabels: {}, variableLabels: []}"))
201+
})
202+
203+
It("should fail when the fqName isn't valid", func() {
204+
m := metric{
205+
kind: prometheus.GaugeValue,
206+
name: "/*3433##",
207+
help: "Can't touch this",
208+
value: 0.003,
209+
}
210+
211+
pm, err := newMetric(m)
212+
213+
Expect(err).Should(HaveOccurred())
214+
Expect(err.Error()).To(Equal("\"/*3433##\" is not a valid metric name"))
215+
Expect(pm).To(BeNil())
216+
})
217+
})
218+
})
219+
220+
//helper function to load json data from the testdata folder
221+
func loadData(path string) []byte {
222+
b, err := ioutil.ReadFile("testdata/" + path)
223+
if err != nil {
224+
panic(err)
225+
}
226+
return b
227+
}
228+
229+
var _ = Describe("Exporter", func() {
230+
const timeout = 5 * time.Second
231+
232+
var (
233+
s *ghttp.Server
234+
e *Exporter
235+
236+
//body []byte
237+
)
238+
239+
BeforeEach(func() {
240+
s = ghttp.NewServer()
241+
242+
c := &config{
243+
host: s.URL(),
244+
username: "admin",
245+
password: "public",
246+
node: "emq@" + s.URL(),
247+
apiVersion: "v3",
248+
}
249+
250+
e = NewExporter(c, timeout)
251+
252+
})
253+
254+
AfterEach(func() {
255+
s.Close()
256+
})
257+
258+
It("should send desc to the channel", func(done Done) {
259+
ch := make(chan *prometheus.Desc)
260+
261+
go e.Describe(ch)
262+
Expect(<-ch).To(ContainSubstring("emq_up"))
263+
Expect(<-ch).To(ContainSubstring("emq_exporter_total_scrapes"))
264+
265+
close(done)
266+
})
183267
})

‎types.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,8 @@ type config struct {
3131
// Exporter collects EMQ stats from the given host and exports them using
3232
// the prometheus metrics package.
3333
type Exporter struct {
34-
config *config
35-
client *http.Client
36-
up prometheus.Gauge
37-
totalScrapes prometheus.Counter
34+
config *config
35+
client *http.Client
3836

3937
mu *sync.Mutex
4038
metrics []*metric

0 commit comments

Comments
 (0)