Skip to content

fix: update golang.org/x/sys to support go1.18 build#139

Merged
xujiajun merged 1 commit intonutsdb:masterfrom
ag9920:fix_go118_build
Apr 7, 2022
Merged

fix: update golang.org/x/sys to support go1.18 build#139
xujiajun merged 1 commit intonutsdb:masterfrom
ag9920:fix_go118_build

Conversation

@ag9920
Copy link
Copy Markdown
Contributor

@ag9920 ag9920 commented Apr 7, 2022

Currently go build/test will fail if you're using Golang 1.18. Here's the output:

# golang.org/x/sys/unix
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:28:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:43:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:59:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:75:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:90:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:105:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:121:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:136:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:151:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:166:3: //go:linkname must refer to declared function or variable
../../../../pkg/mod/golang.org/x/[email protected]/unix/zsyscall_darwin_amd64.go:166:3: too many errors
FAIL    github.com/xujiajun/nutsdb [build failed]

This was caused by an old version of golang.org/x/sys (mentioned in this issue).

This PR simply update golang.org/x/sys to support go1.18. I've already test it locally.

@ag9920 ag9920 force-pushed the fix_go118_build branch from 7c465dd to bf4f644 Compare April 7, 2022 02:58
@xujiajun xujiajun merged commit 5efcfe5 into nutsdb:master Apr 7, 2022
@xujiajun xujiajun mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ag9920 @xujiajun