refactor: rewrite managed to support panic rollback#136
Merged
xujiajun merged 1 commit intonutsdb:masterfrom Apr 2, 2022
Merged
refactor: rewrite managed to support panic rollback#136xujiajun merged 1 commit intonutsdb:masterfrom
xujiajun merged 1 commit intonutsdb:masterfrom
Conversation
ag9920
changed the title
ag9920
force-pushed
the
managed_panic_rollback
branch
from
2de09f3 to
fe65852
Compare
xujiajun
reviewed
Apr 2, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ViewandUpdateinternally depend onmanagedfunction to ensure a block of codes were contained in a transaction.Currently NutsDB will check the
errreturned byfnandCommit, if any of them is not nil,tx.Rollback()will be called.But if a panic occurred within
managed, we could not rollback the transaction. This PR rewritemanagedwith defer check to make suretx.Rollback()gets called.