Fixes Issue 7648 which crashes nushell and happens when an alias name is shorter than the alias command and the alias command is an external command.#7779
Merged
kubouch merged 5 commits intonushell:mainfrom Jan 17, 2023
Conversation
Xoffio
changed the title
Contributor
|
Thanks! Let's try it. |
Contributor
|
This PR caused subcommand completions to not work anymore: #7821. I'm not going to revert it before the release because not panicking is more important but it should be fixed. |
Xoffio
added a commit
to Xoffio/nushell
that referenced
this pull request
Feb 7, 2023
Fix already landed with nushell#7779
kubouch
added a commit
to kubouch/nushell
that referenced
this pull request
Feb 17, 2023
…ias name is shorter than the alias command and the alias command is an external command. (nushell#7779)" This reverts commit 8acced5.
kubouch
added a commit
that referenced
this pull request
Feb 18, 2023
# Description Reverts the PR #7779 which breaks subcommand completions. The issues #7648 and #7754 thus still need fixing. This reverts commit 8acced5. # User-Facing Changes Enables subcommand completions. Unfortunately, also brings back the completion panic if alias is shorter than the command name. # Tests + Formatting Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass # After Submitting If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves issue #7648 that happens when an alias name is shorter than an alias command and the alias command is an external command. Example:
$nu.config-patheandtabUser-Facing Changes
None
Tests + Formatting
Done!
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passNote
I apologize if there is code from the #7754. I was actually working on this problem first and then issue #7754 was found and it was easier to fix that one so I fixed that one first....