Repository navigation
uucore translations are once per-thread, which can lead to untranslated error names #19004
Description
Bug report form
- I have done a basic search of the issue tracker to find any existing issues that are similar.
- I have checked that my version is at least the latest stable release available via my installation method.
Describe the bug
disclaimer: based on my very shallow understanding of uutils. hopefully it's correct.
uucorehas atranslate!macro which uses localized names for error message ids- to use this, you first call an initializer with the name of the util. this initialization is thread local
- so this system assumes one
uucoreutil per thread - ...which
nushelldoesn't do - this means if it was already loaded for one util, an error for a different util in the same
nuthread might give an untranslated error name
How to reproduce
both of these must start from a fresh session of nu
> mktemp foo
Error: nu::shell::error
× too few X's in template 'foo'
╭────
1 │ crates/nu-command/src/filesystem/mktemp.rs:119:48
· ────────────────────────┬────────────────────────
· ╰── too few X's in template 'foo'
╰────
vs.
> uname | ignore
> mktemp foo
Error: nu::shell::error
× mktemp-error-too-few-xs
╭────
1 │ crates/nu-command/src/filesystem/mktemp.rs:119:48
· ────────────────────────┬────────────────────────
· ╰── mktemp-error-too-few-xs
╰────
Expected behavior
calling uname before mktemp should not affect mktemp's translations
Configuration
| key | value |
|---|---|
| version | 0.115.2 |
| major | 0 |
| minor | 115 |
| patch | 2 |
| branch | master |
| commit_hash | 9cb59b9 |
| build_os | macos-aarch64 |
| build_target | aarch64-apple-darwin |
| rust_version | rustc 1.98.0 (88d9e12ae 2026-08-18) |
| rust_channel | stable-aarch64-apple-darwin |
| cargo_version | cargo 1.98.0 (797e8a9bc 2026-08-05) |
| build_time | 2026-09-10 13:37:52 +03:00 |
| build_rust_channel | release |
| allocator | standard |
| features | default, lsp, mcp, network, plugin, rustls-tls, sqlite, trash-support |
| installed_plugins | desktop_notifications 0.107.0, formats 0.107.0, highlight 1.4.9+0.107.0, json_path 0.17.1, query 0.107.0, regex 0.19.0, skim 0.22.0, strutils 0.21.0 |
| experimental_options | example=false, dc-glob=true, reorder-cell-paths=true, pipefail=true, enforce-runtime-annotations=true, native-clip=true, cell-path-types=true |
Activity
mkdir errors on already-created dir (#19006)
aakarshitv commentedon Oct 3, 2026
I looked into this. The cause is in
uucore, so nushell can't fix it on its side. Inuucore/src/lib/mods/locale.rs, both levels keep whichever util was set up first:setup_localization()returns early once any util has been set up on the current thread, so a laterlocalized_help_template("mktemp")does nothing.UTIL_FLUENT: OnceLock. So even a fresh thread gets the first util's strings:[1] | par-each {|_| uname | ignore }; mktemp fooalso printsmktemp-error-too-few-xs.The error types call
translate!in theirDisplayimpls, so there's nothing to route around in nushell. I tested a small uucore patch (a per-util cache, and rebuilding the thread's localizer when the util changes) through[patch.crates-io]. With it, all of the cases above print the translated message.I've opened uutils/coreutils#15040 upstream with the repro and proposed fix, and I'll bump uucore here once it lands. Separately,
platform/whoami.rspasses"touch"tolocalized_help_template. I'll fix that in a small PR.fdncred commentedon Oct 3, 2026
Thanks. I assume someone will have to submit a PR to get it fixed. Do you have time to do that?
aakarshitv commentedon Oct 3, 2026
Yes, I'm down to work on that
aakarshitv commentedon Oct 3, 2026
Opened both:
uname | ignore; mktemp foorepro against a nushell build with the patch, and the error is translated now.whoamicommand #19144 is the small nushell-side fix wherewhoamiwas loadingtouch's translations.Once uutils/coreutils#15044 is merged and released, nushell just needs a uucore bump.
Use whoami's own uucore locale in the `whoami` command (#19144)