Skip to content

fix: helm plan shows base64 parse error for every secret#1939

Merged
im-Amitto merged 1 commit into
mainfrom
am/fix-helm-diff-redaction
Jul 19, 2026
Merged

fix: helm plan shows base64 parse error for every secret#1939
im-Amitto merged 1 commit into
mainfrom
am/fix-helm-diff-redaction

Conversation

@im-Amitto

Copy link
Copy Markdown
Contributor

Chart-rendered Secrets in the dashboard's "Sync and plan" view show
+ Error parsing new secret: error unmarshaling JSON: while decoding JSON: illegal base64 data at input byte 8
instead of the redacted diff (seen on every helm component deploy in the lovable-enterprise azure install).

Cause: helm-diff's redactSecrets mutates the manifest maps in place — it rewrites each Secret's data: values to REDACTED # (n bytes) / ++++++++ # (n bytes). getDiff runs two passes (diff, then diffReport) over the same map[string]*manifest.MappingResult, so the second pass re-parses already-redacted content: both placeholders are 8 valid base64 chars followed by a space, hence the constant "byte 8" failure, and the fork replaces the whole Secret with the parse error. Upstream never hits this because the CLI does a single pass.

Fix: give each pass its own shallow copy of the maps.

@im-Amitto im-Amitto added the promote-all Trigger a promotion of all nuon services and binaries. label Jul 19, 2026
@im-Amitto
im-Amitto merged commit 2e41b49 into main Jul 19, 2026
29 checks passed
@im-Amitto
im-Amitto deleted the am/fix-helm-diff-redaction branch July 19, 2026 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-update promote-all Trigger a promotion of all nuon services and binaries.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants