fix: helm plan shows base64 parse error for every secret#1939
Merged
Conversation
RealHarshThakur
approved these changes
Jul 18, 2026
onprem
approved these changes
Jul 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chart-rendered Secrets in the dashboard's "Sync and plan" view show
+ Error parsing new secret: error unmarshaling JSON: while decoding JSON: illegal base64 data at input byte 8instead of the redacted diff (seen on every helm component deploy in the lovable-enterprise azure install).
Cause: helm-diff's
redactSecretsmutates the manifest maps in place — it rewrites each Secret'sdata:values toREDACTED # (n bytes)/++++++++ # (n bytes).getDiffruns two passes (diff, thendiffReport) over the samemap[string]*manifest.MappingResult, so the second pass re-parses already-redacted content: both placeholders are 8 valid base64 chars followed by a space, hence the constant "byte 8" failure, and the fork replaces the whole Secret with the parse error. Upstream never hits this because the CLI does a single pass.Fix: give each pass its own shallow copy of the maps.