Skip to content

fix: qualify and upsert Cloud DNS NS delegation records#1931

Merged
im-Amitto merged 1 commit into
mainfrom
am/fix-cloud-dns-ns-rrdata-trailing-dot
Jul 16, 2026
Merged

fix: qualify and upsert Cloud DNS NS delegation records#1931
im-Amitto merged 1 commit into
mainfrom
am/fix-cloud-dns-ns-rrdata-trailing-dot

Conversation

@im-Amitto

@im-Amitto im-Amitto commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Follow-up to #1929. Two fixes to install DNS delegation into GCP Cloud DNS parent zones (e.g. Lovable BYOC installs.lovable.dev):

  1. Cloud DNS requires NS rrdata to be fully-qualified; Route53 nameservers (AWS installs) come without a trailing dot, so Cloud DNS returned 400. Qualify each nameserver.
  2. The GCP path used additions-only, so retries/reprovisions failed with 409 alreadyExists. Make it a true upsert (delete existing + add in one change, no-op when unchanged).

@im-Amitto im-Amitto added the promote-all Trigger a promotion of all nuon services and binaries. label Jul 16, 2026
@im-Amitto
im-Amitto enabled auto-merge (squash) July 16, 2026 10:49
@im-Amitto
im-Amitto merged commit 2f1b2ad into main Jul 16, 2026
28 checks passed
@im-Amitto
im-Amitto deleted the am/fix-cloud-dns-ns-rrdata-trailing-dot branch July 16, 2026 10:57
@im-Amitto im-Amitto changed the title fix: qualify Cloud DNS NS rrdata with trailing dot fix: qualify and upsert Cloud DNS NS delegation records Jul 16, 2026
@im-Amitto im-Amitto mentioned this pull request Jul 16, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RealHarshThakur RealHarshThakur RealHarshThakur approved these changes

Assignees

No one assigned

Labels

api auto-update canary integration promote-all Trigger a promotion of all nuon services and binaries.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@im-Amitto @RealHarshThakur