An array TestCase parameter can be assigned to an IEnumerable<T>#924
Merged
An array TestCase parameter can be assigned to an IEnumerable<T>#924
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where array TestCase parameters could not be properly assigned to generic enumerable types. The fix enhances the type compatibility checking to handle array-to-enumerable conversions.
- Enhanced type compatibility checking to support array-to-enumerable conversions for TestCase parameters
- Refactored nullable type handling and enum conversion logic for better clarity
- Added comprehensive test coverage for various generic enumerable types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/nunit.analyzers/Extensions/AttributeArgumentTypedConstantExtensions.cs | Enhanced CanAssignTo method to handle array-to-enumerable conversions and refactored type handling logic |
| src/nunit.analyzers.tests/TestCaseUsage/TestCaseUsageAnalyzerTests.cs | Added test cases to verify array parameters work with generic enumerable types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mikkelbu
approved these changes
Oct 6, 2025
Member
mikkelbu
left a comment
mikkelbu
left a comment
There was a problem hiding this comment.
Thanks for the fix @manfred-brands. I'll merge it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #922