Fix NUnit1001 with multiple args#915
Merged
manfred-brands merged 1 commit intonunit:masterfrom Sep 26, 2025
Merged
Conversation
cbersch
commented
Sep 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with NUnit analyzer rule NUnit1001 when handling TestCase attributes with multiple arguments. The fix ensures proper parameter type mismatch detection for all argument positions, not just single or array-based arguments.
- Adds fallback logic to handle constructor argument syntax retrieval for multi-argument scenarios
- Includes comprehensive test coverage for multiple argument type mismatch scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nunit.analyzers/Extensions/AttributeDataExtensions.cs | Adds else clause to handle constructor argument syntax for non-array initializer cases |
| src/nunit.analyzers.tests/TestCaseUsage/TestCaseUsageAnalyzerTests.cs | Adds two new test cases for multi-argument type mismatch validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
manfred-brands
approved these changes
Sep 26, 2025
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @cbersch
Nice work including tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #914