Add limited support for using var scope = Assert.EnterMultipleScope()#913
Merged
Add limited support for using var scope = Assert.EnterMultipleScope()#913
using var scope = Assert.EnterMultipleScope()#913Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds limited support for detecting using var scope = Assert.EnterMultipleScope() declarations to prevent false positives in the UseAssertMultiple analyzer. The change addresses user reports about this usage pattern not being recognized.
- Extends the analyzer to detect local declaration statements with
usingkeyword that initialize variables withAssert.EnterMultipleScope() - Adds test coverage for the new declaration pattern and edge cases
- Updates variable naming in existing tests from PascalCase to camelCase
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| AssertHelper.cs | Adds logic to detect using var scope = Assert.EnterMultipleScope() declarations within the current scope |
| UseAssertMultipleCodeFixTests.cs | Updates variable naming from PascalCase to camelCase for consistency |
| UseAssertMultipleAnalyzerTests.cs | Adds tests for the new declaration pattern and removes conditional compilation guard |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mikkelbu
approved these changes
Sep 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #910
It does not detect users calling
Dispose()on the declared variable.I'm a bit reluctant to add this, but we have had 2 independent reports about users using this declaration.