Don't treat typeof(T) as a constant as it depends on parameters.#906
Merged
Don't treat typeof(T) as a constant as it depends on parameters.#906
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #896 by preventing the analyzer from treating typeof(T) expressions as constants when T is a type parameter. The analyzer was incorrectly flagging typeof(T) as a constant value, but since it depends on generic type parameters, its value is determined at runtime and should not be considered constant.
- Added special case handling for
typeofoperations with type parameters - Added test coverage to verify the fix works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ConstActualValueUsageAnalyzer.cs | Added logic to exclude typeof(T) operations from constant value detection when T is a type parameter |
| ConstActualValueUsageAnalyzerTests.cs | Added test case to verify that typeof(T) with generic type parameters is not flagged as a constant |
manfred-brands
force-pushed
the
Issue896_typeof_generic
branch
from
6eec4f6 to
fa4f130
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #896