Issue/892 enter multiple scope and null#893
Merged
manfred-brands merged 2 commits intomasterfrom Jun 15, 2025
Merged
Conversation
… Assert.EnterMultipleScope
mikkelbu
approved these changes
Jun 14, 2025
Member
mikkelbu
left a comment
mikkelbu
left a comment
There was a problem hiding this comment.
Looks great @manfred-brands 👍. I've only a single question, but I'm happy to merge this when you are
| ExpectedDiagnostic.Create(DereferencePossiblyNullReferenceSuppressor.SuppressionDescriptors["CS8602"]), | ||
| testCode); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Since we added test for "UsingBlock" and "UsingStatement" should we also add a case for "UsingDeclearation" ?
Member
Author
There was a problem hiding this comment.
The using declaration is covered by the LocalDeclarationStatementSyntax.
But the use cases there (Assert.Throw etc) are not IDisposable.
I'm not covering the Assert.EnterMultipleScope outside of a using statement.
See the conversation in #816
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #892
Doubled all Assert.Multiple tests to also test Assert.EnterMultipleScope by converting them to parameterized tests.
One test failed because a using statement was not traversed.
Updated code to check the statements of the using.
Added new tests where null suppressing asserts where done inside the using statement.