Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the test method signature for Assert.EnterMultipleScope by ensuring that the code fix correctly updates async test methods. Key changes include:
- Addition of tests for both ValueTask and Task-returning methods using Assert.MultipleAsync.
- Updates to the code fix logic in UseAssertEnterMultipleScopeCodeFix, replacing the IsAsyncTaskMethod check with a direct async modifier check.
- Enhancements to diagnostic tests verifying the analyzer behavior for multiple async contexts.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/nunit.analyzers.tests/UseAssertEnterMultipleScope/UseAssertEnterMultipleScopeCodeFixTests.cs | Adds tests verifying the code fix correctly replaces Assert.MultipleAsync with using Assert.EnterMultipleScope. |
| src/nunit.analyzers.tests/UseAssertEnterMultipleScope/UseAssertEnterMultipleScopeAnalyzerTests.cs | Introduces new tests for diagnostic analysis on async methods. |
| src/nunit.analyzers.codefixes/UseAssertEnterMultipleScope/UseAssertEnterMultipleScopeCodeFix.cs | Updates the condition for applying the code fix by checking for the async modifier, eliminating the legacy IsAsyncTaskMethod. |
manfred-brands
approved these changes
Jun 12, 2025
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @mikkelbu for the quick fix.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #888