feat: Also consider typeof(T) as a constant#882
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the constant‐value analyzer to recognize typeof(T) as a constant and adds a test for Assert.That using typeof.
- Extend the early-return condition to skip reporting on
typeofoperations - Add a new unit test targeting
Assert.That(typeof(string), …)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/nunit.analyzers/ConstActualValueUsage/ConstActualValueUsageAnalyzer.cs | Allow OperationKind.TypeOf through the constant-value check |
| src/nunit.analyzers.tests/ConstActualValueUsage/ConstActualValueUsageAnalyzerTests.cs | Add test covering Assert.That when the actual argument is typeof |
Comments suppressed due to low confidence (1)
src/nunit.analyzers.tests/ConstActualValueUsage/ConstActualValueUsageAnalyzerTests.cs:472
- Add a complementary test for other assertion methods (e.g.,
Assert.AreEqual(typeof(X), ...)) to ensure the analyzer consistently flagstypeofacross all assertion patterns.
[Test]
Member
manfred-brands
left a comment
manfred-brands
left a comment
There was a problem hiding this comment.
Thanks @mikkelbu.
No comments looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #880