Added new analyzer to check usage of the RangeAttribute#869
Merged
Conversation
manfred-brands
force-pushed
the
Issue089_RangeAttribute
branch
from
6f22014 to
ffe11e9
Compare
mikkelbu
approved these changes
May 29, 2025
Member
mikkelbu
left a comment
mikkelbu
left a comment
There was a problem hiding this comment.
Thanks for the PR @manfred-brands 🥇. It looks great. I only have some minor comments/questions, but I'm happy to merge it when you are 👍.
* Checks for '0' step * Checks for 'from' <= 'to' when 'step' is positive. * Checks for 'from' >= 'to' when 'step' is negative. * Checks for matching types between Range arguments and parameter declaration
Co-authored-by: Mikkel Nylander Bundgaard <[email protected]>
manfred-brands
force-pushed
the
Issue089_RangeAttribute
branch
from
bd8287f to
582109c
Compare
Member
Author
|
Thanks @mikkelbu for your review. All changes applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #89
Added new analyzer to check usage of the RangeAttribute