Skip to content

Add note about works with unity3d#489

Merged
mikkelbu merged 2 commits intonunit:masterfrom
nowsprinting:chore/note_for_unity3d
Jan 21, 2023
Merged

Add note about works with unity3d#489
mikkelbu merged 2 commits intonunit:masterfrom
nowsprinting:chore/note_for_unity3d

Conversation

@nowsprinting
Copy link
Copy Markdown
Contributor

Unity Test Framework (standard testing framework of unity3d) is based on NUnit3.
Therefore, this analyzer is very useful.

But, the user should use an analyzer built with the same version as Microsoft.CodeAnalysis.CSharp embedded in the Unity Editor follows:

  • Unity under 2021.2: Microsoft.CodeAnalysis.CSharp v3.5.0
  • Unity 2021.2 or later: Microsoft.CodeAnalysis.CSharp v3.9.0

I added a caution about this in the README.md

@dnfadmin
Copy link
Copy Markdown

dnfadmin commented Nov 14, 2022

CLA assistant check
All CLA requirements met.

Comment thread README.md Outdated
Copy link
Copy Markdown
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @nowsprinting. I'll merge it now

@mikkelbu mikkelbu merged commit fc015ff into nunit:master Jan 21, 2023
@mikkelbu mikkelbu added this to the Release 3.6 / 2.6 milestone Jan 21, 2023
@nowsprinting nowsprinting deleted the chore/note_for_unity3d branch January 21, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants