Honor DOTNET_ROOT environment variables#1495
Conversation
|
@CharliePoole, what's the process for getting changes like this migrated over to v4? I just noticed that this isn't in the most recent v4 tag. |
|
@veleek It's listed as done in #1547. I used these kinds of issues to document what needed to be ported but I didn't document what didn't need porting, like bug fixes for features removed in V4. For now, I'm just trusting my past self's judgement. :-) In this case, you'll find that there is a file DotNet.cs in nunit.common, which is identical to DotNetHelper.cs. So if there's any bug in V4, it's a new bug. I created the V4 tag after the fact as a convenient way of tying all V4 stuff together but I may not have captured PRs for ported changes for which no separate V4 issue was created. AFAIK the porting issue for 3.20 is the only one with incomplete work. |
Fixes #1381
This PR also consolidates the code for locating the dotnet install directory in one place.