Skip to content

Backport tests from PR #4692 to 3.x#4708

Merged
OsirisTerje merged 2 commits into
nunit:v3from
stevenaw:v3-4598-timeout-context-output-snapshot
May 26, 2024
Merged

Backport tests from PR #4692 to 3.x#4708
OsirisTerje merged 2 commits into
nunit:v3from
stevenaw:v3-4598-timeout-context-output-snapshot

Conversation

@stevenaw

@stevenaw stevenaw commented May 8, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Backport tests from #4692
To verify the functionality from 3.x that we're restoring. Relates to #4598

This PR also switches the macos image on github actions to target specifically macos-12 in order to work around this NET5-related issue: dotnet/runtime#48068. It seems this may be the first time we're running CI on the 3.x branch since macos-latest was changed to macos-14 and the newer silicon architecture.

@stevenaw stevenaw marked this pull request as draft May 11, 2024 01:07
@stevenaw stevenaw force-pushed the v3-4598-timeout-context-output-snapshot branch from ef7f0d2 to 49cd8f8 Compare May 13, 2024 02:58
@stevenaw

stevenaw commented May 20, 2024

Copy link
Copy Markdown
Member Author

@nunit/framework-team
I've noticed net5 tests still running on the 3.x branch are now failing on macos. That runtime has been EOL for a while and is no longer used in main. Any objections to me removing it from 3.x either within this PR or separately?

@OsirisTerje

OsirisTerje commented May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

I believe we have stated that 3.X will continue to support these OOD frameworks.
Can't we just disable that test from MacOS, and make a note of it ?
I believe we do have some more of those, which have been marked the same way, I think using the Platform attribute.

@stevenaw

stevenaw commented May 20, 2024

Copy link
Copy Markdown
Member Author

Thanks @OsirisTerje I can try to take a closer look.

@stevenaw

stevenaw commented May 20, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Huh interesting. Thanks for having me take a closer look here @OsirisTerje
I had thought it was a NET5 EOL issue but the real thing here was that macos-latest switched to macos-14 which uses newer Apple Silicon / M1+. It appears this was a known issue a few years back with NET5 not working there in all cases: dotnet/runtime#48068

Switching the image from macos-latest down to macos-12 seems to have solved it. macos-12 is still supported and not yet deprecated based on https://github.com/actions/runner-images?tab=readme-ov-file.

I think this is ready to switch out of Draft

@stevenaw stevenaw marked this pull request as ready for review May 20, 2024 19:46
@OsirisTerje

OsirisTerje commented May 20, 2024

Copy link
Copy Markdown
Member

@stevenaw Awesome! And agree!

OsirisTerje
OsirisTerje approved these changes May 20, 2024
View reviewed changes

@OsirisTerje OsirisTerje left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OsirisTerje OsirisTerje merged commit 7f6fe9b into nunit:v3 May 26, 2024
@stevenaw

stevenaw commented May 26, 2024

Copy link
Copy Markdown
Member Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OsirisTerje OsirisTerje OsirisTerje approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stevenaw @OsirisTerje