TestCaseSource unable to pass one element byte array#2310
Merged
rprouse merged 1 commit intonunit:masterfrom Jul 12, 2017
Stan-RED:fixes/issues-1851
Merged
TestCaseSource unable to pass one element byte array#2310rprouse merged 1 commit intonunit:masterfrom Stan-RED:fixes/issues-1851
rprouse merged 1 commit intonunit:masterfrom
Stan-RED:fixes/issues-1851
Conversation
jnm2
reviewed
Jul 12, 2017
| args = new object[array.Length]; | ||
| for (int i = 0; i < array.Length; i++) | ||
| for (var i = 0; i < array.Length; i++) | ||
| args[i] = array.GetValue(i); |
Contributor
There was a problem hiding this comment.
array.CopyTo(args, 0); is also an option.
jnm2
approved these changes
Jul 12, 2017
jnm2
reviewed
Jul 12, 2017
| [Test, TestCaseSource("MyArrayData")] | ||
| public void SourceMayReturnArrayForArray(int[] array) | ||
| { | ||
| Assert.That(true); |
Contributor
There was a problem hiding this comment.
Assert.Pass(); or an empty method body are also options.
rprouse
approved these changes
Jul 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #2104 I have also optimized TestCaseSourceAttribute and additionally check it against this issue. Looks like it is fixed.
Fixes #1851