I have some of these changes sitting in a branch. Should I go back to it, wrap it up, and open a PR? Or should I wait until we know when we'll be releasing it?

…

On Tue, Jun 27, 2017, 09:04 Rob Prouse ***@***.***> wrote: If we follow SemVer to the letter, then we probably should hold off on this to a 4.0 release. I think you could argue though that since most of the attributes were obsoleted in 3.0 and there have been many releases to fix the warnings it isn't a breaking change. AFAIK, the only obsolete feature that isn't a simple search and replace update is the AssertHelper. AssertHelper has only been obsolete for one release, so removing it may be pre-mature. Updating everything else should only take a few minutes, even for large solutions. @nn <https://github.com/nn> or @Lette <https://github.com/lette> is there anything other than AssertHelper that you see as a major or difficult change? Personally, I am surprised that people haven't already updated their code, but maybe I just hate warnings more than other people 😄 I am also surprised that people continue to use AssertHelper since it is so limited compared to the other asserts. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2219 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAa2JNn3PuJAEzRw_L5jW5jpwR-2oOUvks5sIP35gaJpZM4Nvhbo> .

Remove Obsolete Attributes #2219

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions