feat: run the same formatter in parallel for many files#282
Merged
zimbatm merged 1 commit intonumtide:mainfrom Apr 19, 2024
Merged
feat: run the same formatter in parallel for many files#282zimbatm merged 1 commit intonumtide:mainfrom
zimbatm merged 1 commit intonumtide:mainfrom
Conversation
Member
|
Nice. Do you know if pariter still respects the number of threads when invoked recursively? This change could have implications for machines that have access to less resources. |
Contributor
Author
|
No more threads are spawned than available cores: https://github.com/rayon-rs/rayon/blob/main/FAQ.md#how-many-threads-will-rayon-spawn |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the website I'd have thought this would be done already, but after running it over Nixpkgs it turns out it's not.
Parallel formatting seems to originally have been implemented by @basile-henry in #17, which subsequently didn't make it in @zimbatm's #68. While #71 attempted to re-implement it, it only runs each formatter in parallel, but not individual files for the same formatter.
This PR fixes that, making each chunk of 1024 files run in parallel (so no extra parallelism if there's less than that number of files).
I tested this with
with https://github.com/NixOS/nixfmt on https://github.com/nixos/nixpkgs/ and can confirm that it sped it up considerably.
This work is sponsored by Antithesis ✨