Skip to content

nix: move ci dependencies to the devShell#161

Merged
zimbatm merged 1 commit intonumtide:masterfrom
TristanCacqueray:nix-shell
May 12, 2022
Merged

nix: move ci dependencies to the devShell#161
zimbatm merged 1 commit intonumtide:masterfrom
TristanCacqueray:nix-shell

Conversation

@TristanCacqueray
Copy link
Contributor

Fixes #160

@zimbatm
Copy link
Member

zimbatm commented May 5, 2022

 = note: ld: library not found for -liconv
          clang-7: error: linker command failed with exit code 1 (use -v to see invocation)

I'm not sure why this is failing on macOS

@TristanCacqueray
Copy link
Contributor Author

@zimbatm shouldn't the override appends to the treefmt buildInputs? e.g. to keep that definition:

buildInputs = with nixpkgs; lib.optionals stdenv.isDarwin [ darwin.apple_sdk.frameworks.Security libiconv ];

@zimbatm
Copy link
Member

zimbatm commented May 5, 2022

doh. that's probably it :)

@zimbatm zimbatm mentioned this pull request May 8, 2022
@zimbatm
Copy link
Member

zimbatm commented May 11, 2022

@TristanCacqueray nativeBuildInputs probably also needs to be concatenated with prev.nativeBuildInputs

@TristanCacqueray
Copy link
Contributor Author

@zimbatm oh, ok I've squashed the change. We'll get through this eventually :)

@zimbatm
Copy link
Member

zimbatm commented May 12, 2022

success!

@zimbatm zimbatm merged commit be1d854 into numtide:master May 12, 2022
@TristanCacqueray
Copy link
Contributor Author

nice, thanks!

brianmcgee pushed a commit to brianmcgee/treefmt that referenced this pull request Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The default nix flake installable is heavy

2 participants