🤖 type-test generation for ndarray (binary) operators
#487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For$\approx49\%$ ) of those are currently failing (according to
ndarray.__add__this will generate 385 tests, but 190 (basedpyright). I'll address these in a follow-up.Note that this does not test shape-types, and only tests the "homogenous" ndarray x ndarray case (so no builtin scalars, numpy scalars, or other array-likes).
This also does not cover the abstract scalar-types; only the concrete ones. So e.g.
NDArray[np.integer]is not covered by these.Towards #491