Repository navigation
MAINT: Separate correct longdouble.__float__ from incorrect longdouble.__int__ - #9967
Merged
Merged
Conversation
eric-wieser
commented
Nov 5, 2017
Member
Author
There was a problem hiding this comment.
Using PyArrayScalar_VAL in favor of this
Member
Author
There was a problem hiding this comment.
This repeat is way clearer expressed as two repeats
Member
Author
There was a problem hiding this comment.
This is where things need to change to fix #9964, but lets leave that to a future PR.
Member
Author
There was a problem hiding this comment.
This is deliberate, as nb_int should try to return int on py2, but long on py3. I'm not sure it makes a difference externaly (I suspect python deals with either return value), but it's more consistent with how longobject is implemented.
Member
Author
There was a problem hiding this comment.
It's far more readable and concise to iterate over the types here, rather than the members.
…uble.__int__` These barely shared any useful code at all.
eric-wieser
force-pushed
the
separate-longdouble-int
branch
from
November 5, 2017 23:26
49c624a to
7b4ec2a
Compare
Member
|
Thanks Eric. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These barely shared any useful code at all, and it makes it clearer where the fix needs to go for #9964