BUG: ensure structured ndarray.__eq__,__ne__ defer when appropriate. #9167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhvk
added
09 - Backport-Candidate
eric-wieser
reviewed
May 23, 2017
Member
There was a problem hiding this comment.
Don't we need this in NE too?
Contributor
Author
There was a problem hiding this comment.
Geez, I'm not being very bright today! And that only shows that my test is wrong too. Will fix!
Contributor
Author
There was a problem hiding this comment.
My initial test did not even use a structured array for the comparison, so it passed trivially! (I did check that the current test fails on master)
This solves the case where `other` is an object that defines a higher `__array_priority__` or `__array_ufunc__ = None`, but not yet the case where it defines its own implementation of `__array_ufunc__`.
mhvk
force-pushed
the
ndarray__eq__override
branch
from
6c7bd01 to
48b4aca
Compare
Member
|
LGTM, thanks Marten. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the case where
otheris an object that defines a higher__array_priority__or__array_ufunc__ = None, but not yet the case where it defines its own implementation of__array_ufunc__. See #9153 for details.