DOC: update 1.13 release note for MaskedArray, masked constants ellipisis indexing#9122
Merged
charris merged 1 commit intonumpy:masterfrom May 16, 2017
Merged
Conversation
ahaldane
force-pushed
the
1.13_note_ma_scalar
branch
from
b1e2559 to
cb0331d
Compare
ahaldane
changed the title
ahaldane
force-pushed
the
1.13_note_ma_scalar
branch
from
cb0331d to
adf8345
Compare
Member
|
Surely "wraps", not "unwraps". Don't forget that this also changes |
ahaldane
force-pushed
the
1.13_note_ma_scalar
branch
from
adf8345 to
c04f359
Compare
Member
Author
|
@eric-wieser , updated. Does this version sound accurate? |
charris
changed the title
charris
reviewed
May 16, 2017
doc/release/1.13.0-notes.rst
Outdated
Member
There was a problem hiding this comment.
Use dashes, '-', not ~ and put the ellipsis in quotes.
charris
changed the title
ahaldane
force-pushed
the
1.13_note_ma_scalar
branch
from
c04f359 to
28b3597
Compare
Member
Author
|
OK, updated as you suggested, and changed the commit title to be DOC too. |
eric-wieser
reviewed
May 16, 2017
doc/release/1.13.0-notes.rst
Outdated
Member
There was a problem hiding this comment.
That should be Ellipsis, not ellipsis. I think @charris' comment was requesting ``...``
Member
Author
There was a problem hiding this comment.
Oh! that makes more sense
…isis indexing Fixes numpy#9121 [ci skip]
ahaldane
force-pushed
the
1.13_note_ma_scalar
branch
from
28b3597 to
f19f01f
Compare
Member
|
Looks good, thanks Allan. |
charris
added a commit
that referenced
this pull request
May 16, 2017
DOC: update 1.13 release note for MaskedArray, masked constants ellipisis indexing (Backport #9122)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9121
(backport coming up)