Repository navigation
BUG: ediff1d should return subclasses - #8218
Merged
Merged
Conversation
Special case to_begin and to_end both equal to None, avoiding subsequent steps. Particulary faster for small arrays where overhead plays a big role.
mattharrigan
force-pushed
the
ediff1d-performance
branch
4 times, most recently
from
October 28, 2016 00:16
f6c519c to
759f943
Compare
mattharrigan
force-pushed
the
ediff1d-performance
branch
from
October 28, 2016 00:17
759f943 to
9a90abf
Compare
Contributor
Author
|
@mhvk can you please test this against astropy? thanks |
Contributor
|
@mattharrigan - yes, this solves the astropy regressions. And as you suggested and I belated realised was true, with the @charris -- I think this is good to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes regression in astropy. Follow up to PR #8183