Skip to content

Conversation

@madphysicist
Copy link
Contributor

The changes in this bug are extracted from #7804, where they are duplicated. This PR is intended to be non-controversial since it is just a bug-fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the list should not be needed, you can create a tuple from a generator (though it doesn't really make a significant difference here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a direct copy of old version line ~272. I thought there were some issues with using a generator expression in older versions of Python, so I kept it this way. Could be wrong though.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we only support 2.6 (or even 2.7 now?) so that should not be an issue
but its also not necessary to change it, more of a keep in mind that you can do that comment :)

@juliantaylor juliantaylor merged commit f12412d into numpy:master Aug 27, 2016
@juliantaylor
Copy link
Contributor

thanks

@homu homu mentioned this pull request Aug 27, 2016
@madphysicist madphysicist deleted the ma-bugs branch August 29, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants