Skip to content

Restore histogram consistency#7667

Merged
charris merged 2 commits intonumpy:masterfrom
rkern:fix/histogram-accuracy
May 24, 2016
Merged

Restore histogram consistency#7667
charris merged 2 commits intonumpy:masterfrom
rkern:fix/histogram-accuracy

Conversation

@rkern
Copy link
Copy Markdown
Member

@rkern rkern commented May 24, 2016

@charris This should do it. Not sure about the performance.

The method here is to use the computed index as the initial guess, check the data against the bin that it points to, and adjust up or down by 1 as needed.

Fuzz test: https://gist.github.com/rkern/840b67903e0d033ede1ad47f54aa4200

Fixes #7628

@charris charris added this to the 1.11.1 release milestone May 24, 2016
@charris charris merged commit 85f6640 into numpy:master May 24, 2016
@charris
Copy link
Copy Markdown
Member

charris commented May 24, 2016

Thanks Robert.

@homu homu mentioned this pull request May 24, 2016
@charris charris removed this from the 1.11.1 release milestone May 24, 2016
@rkern rkern deleted the fix/histogram-accuracy branch June 6, 2016 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants