Repository navigation
BUG: scalar integer negative powers gave wrong results. - #7447
Merged
Merged
Conversation
np.int8(4)**np.int8(-4) gave inf. Since we result a float or double for these cases, just call those power routines. This prevents integer overflow from resulting in a divide by zero and the old nonsense result.
Contributor
Author
|
CI failure is curl failing to download python 3.5. So unrelated to these changes. |
Member
|
Hmm, arrays just convert inf to 0, which is the standard cast for integers. also integer result rather than float. So this is a case where numpy scalars behave differently from array scalars. Apart from that inconsistency this looks good to me, but I wonder if we want to stick with it in the long run. Perhaps a note to the mailing list would elicit some discussion. |
Member
|
OTOH, it makes it consistent with Python So let's put this in. The inconsistency is still a bit bothersome. |
Member
|
Thanks @ewmoore . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
np.int8(4)**np.int8(-4) gave inf. Since we return a float or
double for these cases, just call those power routines. This
prevents integer overflow from resulting in a divide by zero and
the old nonsense result.