Skip to content

Conversation

@madphysicist
Copy link
Contributor

Main correction was to fix up outputs in nanpercentile examples and make the docs look more like those of percentile.

@madphysicist
Copy link
Contributor Author

I would like to make the request, if such a thing is possible, to have this PR backported the same way as as #7180, assuming they are both accepted and 7180 is backported. The reason is that most of this change is to the documentation of nanpercentile, so it is very closely related to the code modifications of 7180.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings and comments should wrap at 72 columns, not 79, PEP 8 says so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't argue with PEP8. Fixed. Also, found a couple more typos and changed some wording around while fixing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could remove (...).

@charris charris added this to the 1.11.0 release milestone Feb 5, 2016
@madphysicist madphysicist force-pushed the doc-typos branch 3 times, most recently from f506270 to f2c5b6a Compare February 5, 2016 20:38
@madphysicist madphysicist deleted the doc-typos branch February 7, 2016 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants