TST: Verify dot products with matrix transposes #6930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You want these tests for future work, yes? |
Contributor
Author
|
Correct, this is to make sure I don't mess something up. :) If you have pointers or thoughts on additional tests, I am open to suggestions. |
Contributor
Author
|
I think I should add some inner product tests, as well. |
jakirkham
changed the title
jakirkham
force-pushed
the
test_dot_trans
branch
8 times, most recently
from
330b071 to
66eeeae
Compare
jakirkham
changed the title
Contributor
Author
|
I've decided to skip |
…views of its self work correctly.
jakirkham
force-pushed
the
test_dot_trans
branch
from
66eeeae to
e72e151
Compare
Contributor
Author
|
Rebased. |
Member
|
Can't see how more tests could do any harm :-) Thanks @jakirkham |
njsmith
added a commit
that referenced
this pull request
Jan 6, 2016
TST: Verify dot products with matrix transposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #6794
Related: #6932
Tries different products with transposes to verify that correct result is gotten. Makes sure to try combinations that don't share memory, as well.